Find NaN in ArrayUtils.lastIndexOf for double and float arrays#1718
Merged
Conversation
garydgregory
requested changes
Jun 19, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
Would you please add tests for:
java.lang.Double|Float.NEGATIVE_INFINITYjava.lang.Double|Float.POSITIVE_INFINITY
Thank you!
Contributor
Author
|
Done. Added |
garydgregory
added a commit
that referenced
this pull request
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
ArrayUtils.lastIndexOf(new double[]{Double.NaN}, Double.NaN)returns-1, whileArrayUtils.indexOfon the same array returns0(andcontainsreturnstrue).Cause:
indexOf(double[])/indexOf(float[])were given explicitNaNmatching (theindexOfNaNhelper fordouble, asearchNaNflag forfloat), but thelastIndexOfoverloads still only compare withvalueToFind == array[i], which is nevertrueforNaN.Fix: route the two
doublelastIndexOfoverloads (withstartIndex, and withstartIndex+tolerance) through a new privatelastIndexOfNaNhelper that mirrorsindexOfNaN, and add the samesearchNaNcheck tolastIndexOf(float[], float, int), solastIndexOfagrees withindexOfonNaN.mvn; that'smvnon the command line by itself.