Snowflake: Add support for CREATE FILE FORMAT#2336
Open
ramnes wants to merge 1 commit intoapache:mainfrom
Open
Snowflake: Add support for CREATE FILE FORMAT#2336ramnes wants to merge 1 commit intoapache:mainfrom
ramnes wants to merge 1 commit intoapache:mainfrom
Conversation
This PR adds a `Statement::CreateFileFormat` variant and parses the full grammar:
`CREATE [ OR REPLACE ] [ { TEMP | TEMPORARY | VOLATILE } ] FILE FORMAT [ IF NOT EXISTS ] <name> [ formatTypeOptions ] [ COMMENT = '<string>' ]`
Format options are stored as `KeyValueOptions`, with `COMMENT` split out into its own `Option<String>` field to match `CREATE STAGE`. `IDENTIFIER(?)` style names are handled via `parse_object_name(true)`.
Closes apache#2070.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
Statement::CreateFileFormatvariant and parses the full grammar:CREATE [ OR REPLACE ] [ { TEMP | TEMPORARY | VOLATILE } ] FILE FORMAT [ IF NOT EXISTS ] <name> [formatTypeOptions ] [ COMMENT = '<string>' ]Format options are stored as
KeyValueOptions, withCOMMENTsplit out into its ownOption<String>field to matchCREATE STAGE.IDENTIFIER(?)style names are handled viaparse_object_name(true).Closes #2070