Skip to content

[fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner#62343

Merged
gavinchou merged 1 commit intoapache:masterfrom
dataroaring:fix/remove-stale-compile-check-include
Apr 15, 2026
Merged

[fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner#62343
gavinchou merged 1 commit intoapache:masterfrom
dataroaring:fix/remove-stale-compile-check-include

Conversation

@dataroaring
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring commented Apr 10, 2026

Summary

Root Cause

PR #62077 and PR #62300 were prepared independently. #62077 added a new file with the compile_check includes, while #62300 deleted those headers. After both merged, master fails to compile with:

fatal error: 'common/compile_check_begin.h' file not found

Test plan

  • Verify master compiles successfully after this change

🤖 Generated by ThinkOps — autonomous agent pipeline

…appings_scanner

PR apache#62077 added schema_role_mappings_scanner.cpp with compile_check_begin/end.h
includes, but PR apache#62300 subsequently deleted those headers globally. This causes
a compile failure on master: 'common/compile_check_begin.h' file not found.

Generated by Claude Code
Copilot AI review requested due to automatic review settings April 10, 2026 09:42
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Copy Markdown
Contributor Author

run buildall

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a build break on master by removing references to deleted compile-check wrapper headers from the BE information_schema role mappings scanner.

Changes:

  • Removed stale common/compile_check_begin.h / common/compile_check_end.h includes from schema_role_mappings_scanner.cpp.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@gavinchou gavinchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Simple and necessary fix for the compile break caused by the race condition between #62077 and #62300.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.65% (27398/37198)
Line Coverage 57.31% (295843/516243)
Region Coverage 54.53% (246453/451925)
Branch Coverage 56.19% (106823/190105)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.66% (27401/37198)
Line Coverage 57.31% (295884/516243)
Region Coverage 54.56% (246586/451925)
Branch Coverage 56.21% (106861/190105)

@hello-stephen
Copy link
Copy Markdown
Contributor

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings.

Critical checkpoint conclusions:

  • Goal and correctness: The PR removes two stale common/compile_check_begin.h / common/compile_check_end.h includes from be/src/information_schema/schema_role_mappings_scanner.cpp, which directly resolves the reported build failure after those headers were deleted in #62300. The file content remains consistent with sibling scanners in the same directory.
  • Scope and clarity: The change is as small and focused as possible: exactly the two invalid includes are removed, with no behavioral edits.
  • Concurrency: Not applicable. This change does not modify any threaded code, shared state, or lock behavior.
  • Lifecycle/static initialization: No new lifecycle or static initialization behavior is introduced.
  • Configuration: No config changes.
  • Compatibility: No FE/BE protocol, storage format, symbol, or rolling-upgrade compatibility impact.
  • Parallel code paths: I checked the be/src/information_schema scanner implementations and they already follow the post-#62300 pattern without these headers, so this file is being brought back into line rather than creating divergence.
  • Special conditions: No new conditional logic is added.
  • Test coverage: There is no targeted test in the PR. For this compile-only fix, the relevant validation is successful BE compilation; I did not run a build in this review environment.
  • Observability: Not applicable. No runtime path changes.
  • Transaction/persistence/data writes: Not applicable. No transaction, persistence, or data-modification logic is touched.
  • FE-BE variable passing: Not applicable. No new transmitted fields.
  • Performance: No performance impact.
  • Other issues: None identified from the changed code and surrounding module conventions.

Residual risk:

  • The only remaining risk is whether CI confirms the intended compile fix, since no local build was run during review.

@gavinchou gavinchou merged commit ab53cf3 into apache:master Apr 15, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants