HBASE-30039 Upgrade hbase-server to use junit5 Part3 (#7999)#8065
Merged
liuxiaocs7 merged 1 commit intoapache:branch-2from Apr 16, 2026
Merged
HBASE-30039 Upgrade hbase-server to use junit5 Part3 (#7999)#8065liuxiaocs7 merged 1 commit intoapache:branch-2from
liuxiaocs7 merged 1 commit intoapache:branch-2from
Conversation
Member
liuxiaocs7
commented
Apr 11, 2026
- for branch-2
- see HBASE-30039
4abd675 to
420525e
Compare
18ec090 to
9dea567
Compare
There was a problem hiding this comment.
Pull request overview
This PR continues the HBASE-30039 effort on branch-2 by migrating quota-related tests in hbase-server from JUnit 4 to JUnit 5 (Jupiter).
Changes:
- Replace JUnit4 annotations/rules/categories with JUnit5
@Test, lifecycle annotations, and@Tag. - Update assertions to JUnit5 equivalents (including
assertThrowsand message-argument ordering). - Replace usages of
TestNamerule withTestInfo-derived names and updateSpaceQuotaHelperForTeststo accept aStringtest name.
Reviewed changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/policies/TestNoWritesViolationPolicyEnforcement.java | Migrate policy enforcement unit test to JUnit5 (@Tag, @BeforeEach, assertThrows). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/policies/TestNoWritesCompactionsViolationPolicyEnforcement.java | Migrate policy enforcement unit test to JUnit5 (@Tag, @BeforeEach, assertThrows). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/policies/TestNoInsertsViolationPolicyEnforcement.java | Migrate policy enforcement unit test to JUnit5 (@Tag, @BeforeEach, assertThrows). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/policies/TestDisableTableViolationPolicyEnforcement.java | Migrate policy enforcement unit test to JUnit5 (@Tag, @BeforeEach, assertThrows). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/policies/TestBulkLoadCheckingViolationPolicyEnforcement.java | Migrate bulk-load policy checks test to JUnit5 and use assertThrows. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestTablesWithQuotas.java | Migrate non-minicluster quota table classification test to JUnit5 assertions and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestTableSpaceQuotaViolationNotifier.java | Migrate notifier test to JUnit5 lifecycle and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestTableQuotaViolationStore.java | Migrate snapshot store test to JUnit5 lifecycle, assertions, and tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSuperUserQuotaPermissions.java | Migrate minicluster permissions test to JUnit5 lifecycle/tags and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasWithSnapshots.java | Migrate snapshot space-quota integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasWithRegionReplicas.java | Migrate region-replica quota integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotas.java | Migrate end-to-end space quota test to JUnit5; replace TestName usage with TestInfo in test methods. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaViolationPolicyRefresherChore.java | Migrate refresher chore unit test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaSwitchPolicies.java | Migrate policy switching integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaRemoval.java | Migrate quota removal integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaOnNonExistingTables.java | Migrate non-existing table quota test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaOnBulkLoad.java | Migrate bulkload quota integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaIncrease.java | Migrate quota increase integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaDropTable.java | Migrate quota-drop-table integration test to JUnit5 assertions/lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaBasicFunctioning.java | Migrate basic space quota integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSnapshotQuotaObserverChore.java | Migrate snapshot observer chore integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRegionSizeUse.java | Migrate region size reporting integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRegionSizeStoreImpl.java | Migrate region size store unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRegionSizeReportingChore.java | Migrate reporting chore unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRegionSizeImpl.java | Migrate region size unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRegionServerSpaceQuotaManager.java | Migrate regionserver quota manager unit test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRateLimiter.java | Migrate rate limiter tests to JUnit5 assertions and @Tag. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaUserOverride.java | Migrate quota override integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaThrottle.java | Migrate throttling test to JUnit5 (@Disabled, lifecycle, tags) and assertions. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaTableUtil.java | Migrate quota table util integration tests to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaStatusRPCs.java | Migrate quota status RPC integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaState.java | Migrate quota state unit test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreWithMiniCluster.java | Migrate quota observer minicluster integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java | Migrate region report retention integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChore.java | Migrate non-minicluster quota observer unit test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaCache2.java | Migrate quota cache unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaCache.java | Migrate quota cache minicluster test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java | Migrate quota admin minicluster tests to JUnit5 lifecycle/tags and assertions. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestNamespaceQuotaViolationStore.java | Migrate namespace snapshot store unit test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterQuotasObserverWithMocks.java | Migrate mock-based master quotas observer unit test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterQuotasObserver.java | Migrate master quotas observer integration tests to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterQuotaManager.java | Migrate master quota manager unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestLowLatencySpaceQuotas.java | Migrate low-latency quota integration tests to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestGlobalQuotaSettingsImpl.java | Migrate global quota settings unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestFileSystemUtilizationChore.java | Migrate FS utilization chore unit test to JUnit5 assertions/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestFileArchiverNotifierImpl.java | Migrate file archiver notifier integration test to JUnit5 and replace TestName with TestInfo. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestFeedbackAdaptiveRateLimiter.java | Migrate adaptive rate limiter unit tests to JUnit5 lifecycle/tags and assertion message ordering. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestDefaultQuota.java | Migrate default quota integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestDefaultOperationQuota.java | Migrate default operation quota unit test to JUnit5 assertions/tags (incl. assertThrows). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestDefaultAtomicQuota.java | Migrate default atomic quota integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestClusterScopeQuotaThrottle.java | Migrate cluster-scope throttling integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestBlockBytesScannedQuota.java | Migrate block-bytes-scanned quota integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestAtomicReadQuota.java | Migrate atomic read quota integration test to JUnit5 lifecycle/tags. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestActivePolicyEnforcement.java | Migrate active policy enforcement unit test to JUnit5 lifecycle/tags and assertion message ordering. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/SpaceQuotaHelperForTests.java | Refactor helper to accept a String test name and update assertion message ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
9dea567 to
67c636b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.