Fix MongoDB transform dialog layout, update-option enablement, and Input preview when not outputting JSON#7165
Merged
Conversation
…put preview when not outputting JSON Signed-off-by: lance <leehaut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI layout and enablement
MongoDbInputDialog): Vertically align the Collection label, combo, and Get collections button on one row (FormAttachment+SWT.CENTER, matching MongoDB Output).MongoDbDeleteDialog): Same Collection row alignment; align Use JSON query label and checkbox on one row (checkbox was offset withmargin * 3).MongoDbOutputDialog): When Update / Modifier update toggles enable or disable Upsert, Multi-update, and Modifier options, apply the same state to their labels viasetUpdateOptionControlsEnabled()(on load, on selection, and after dialog build).MongoDB Input preview / init fix
When Output a single JSON field is unchecked and no fields are defined on the Fields tab, preview failed with:
NullPointerException: Cannot invoke "java.util.List.iterator()" because "fields" is nullat
MongoDbInputData.setMongoFields.