Skip to content

action-allowlist-review: bump nwtgck/actions-netlify from 3.0.0 to 4.0.0 in /.github/actions/for-dependabot-triggered-reviews#915

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/nwtgck/actions-netlify-4.0.0
Open

action-allowlist-review: bump nwtgck/actions-netlify from 3.0.0 to 4.0.0 in /.github/actions/for-dependabot-triggered-reviews#915
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/nwtgck/actions-netlify-4.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 6, 2026

Copy link
Copy Markdown
Contributor

Bumps nwtgck/actions-netlify from 3.0.0 to 4.0.0.

Release notes

Sourced from nwtgck/actions-netlify's releases.

v4.0.0

https://github.com/nwtgck/actions-netlify/blob/develop/CHANGELOG.md

Changelog

Sourced from nwtgck/actions-netlify's changelog.

Changelog

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog

[Unreleased]

[4.0.0] - 2026-06-05

Changed

  • Update dependencies
  • Updates the default runtime to node24

[3.0.0] - 2024-03-10

Changed

  • Update dependencies
  • Updates the default runtime to node20

[2.1.0] - 2023-08-18

Changed

  • Update dependencies

Added

[2.0.0] - 2022-12-08

Changed

  • Update dependencies
  • Updates the default runtime to node16

[1.2.4] - 2022-10-14

Changed

  • Update dependencies

[1.2.3] - 2021-12-20

Changed

  • Update dependencies

[1.2.2] - 2021-05-08

Fixed

  • Fix GitHub deployment description

Changed

  • Update dependencies

[1.2.1] - 2021-05-05

Added

  • Add "fails-without-credentials" input to fail if the credentials not provided #532

Changed

  • Update dependencies

... (truncated)

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jun 6, 2026
@dependabot dependabot Bot requested review from dfoulks1 and potiuk as code owners June 6, 2026 13:18
@dependabot dependabot Bot added the github_actions Pull requests that update GitHub Actions code label Jun 6, 2026
@dependabot dependabot Bot requested a review from ppkarwasz as a code owner June 6, 2026 13:18
@potiuk

potiuk commented Jun 8, 2026

Copy link
Copy Markdown
Member

@dependabot rebase

Bumps [nwtgck/actions-netlify](https://github.com/nwtgck/actions-netlify) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/nwtgck/actions-netlify/releases)
- [Changelog](https://github.com/nwtgck/actions-netlify/blob/develop/CHANGELOG.md)
- [Commits](nwtgck/actions-netlify@4cbaf4c...d22a32a)

---
updated-dependencies:
- dependency-name: nwtgck/actions-netlify
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/nwtgck/actions-netlify-4.0.0 branch from 7d3e847 to c455aa7 Compare June 8, 2026 16:15
@potiuk

potiuk commented Jun 11, 2026

Copy link
Copy Markdown
Member

The verify gate fails this major bump on two counts:

  1. The published dist/ doesn't reproduce from source — rebuilding from the v4.0.0 source (after a tsconfig.json lib: ["es2022"] change) yields a different dist/index.js / dist/thread.js than what's committed.
  2. dist/elf_cam_bg.wasm ships in-tree with no provenance — the v4.0.0 release has no assets (no SHA256SUMS, no SLSA attestation).

So we can't tie the shipped bundle back to the reviewed source. I've filed nwtgck/actions-netlify#1242 upstream asking for a reproducible dist/ build and build provenance for the wasm.

Not merging for now. @dfoulks1 @ppkarwasz — do you think we hold this until upstream resolves #1242, or is there a path you'd prefer (e.g. pin back / drop the entry)? Opinions welcome.

@potiuk

potiuk commented Jun 13, 2026

Copy link
Copy Markdown
Member

⚠️ Holding for manual security review — do not auto-merge.

The verify gate fails this major bump (3.0.0→4.0.0) on its two core reproducibility checks, not on a download-provenance technicality:

In-tree binary check     ✗  unverified binaries in repo (no SLSA attestation)
JS build verification    ✗  DIFFERENCES DETECTED
RESULT: Differences detected between published and rebuilt JS

The committed dist/ bundle for nwtgck/actions-netlify@v4.0.0 does not reproduce from source, and there are in-tree binaries without SLSA attestation. None of the trusted-download escape hatches apply here — this is the exact supply-chain signal the gate is meant to surface.

This may be benign (minifier/toolchain differences) or not — it needs a human to inspect the published-vs-rebuilt diff and the in-tree binaries before this can be approved. Flagging rather than merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant