Skip to content

Improve tests for "check GitHub actions-SHAs"#917

Merged
potiuk merged 7 commits into
apache:mainfrom
snazy:gh-action-sha-tag-check-tests
Jun 11, 2026
Merged

Improve tests for "check GitHub actions-SHAs"#917
potiuk merged 7 commits into
apache:mainfrom
snazy:gh-action-sha-tag-check-tests

Conversation

@snazy

@snazy snazy commented Jun 8, 2026

Copy link
Copy Markdown
Member
  1. Use mocks for all tests that rely on remote repo state
  2. Introduce GH API helper tests
  3. Improve overall test coverage

@snazy

snazy commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Follow-up for #356

@potiuk

potiuk commented Jun 8, 2026

Copy link
Copy Markdown
Member

@snazy When you pick this back up, could you rebase onto latest main? Keeping the open PRs current with main. Thanks!

@snazy snazy force-pushed the gh-action-sha-tag-check-tests branch from 6d3c42b to ce8e53d Compare June 11, 2026 15:56
@snazy snazy marked this pull request as ready for review June 11, 2026 17:37

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great follow-up. Addresses 4 of the 5 nits from #356json.loads for API bodies, exact-tag matching that drops prefix-matched siblings, the wildcard + untagged-SHA ordering fix, and the typo — each with a regression test (test_matching_tag_prefix_results_do_not_satisfy_shorter_tag, test_wildcard_after_untagged_sha_records_mixed_ref_warning). Live API calls are now mocked, with the real ones gated behind GH_TOKEN. 36 tests, all green. LGTM — thanks!

@potiuk potiuk merged commit 6e68463 into apache:main Jun 11, 2026
10 checks passed
@snazy snazy deleted the gh-action-sha-tag-check-tests branch June 12, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants