Improve tests for "check GitHub actions-SHAs"#917
Merged
Conversation
snazy
commented
Jun 8, 2026
Member
- Use mocks for all tests that rely on remote repo state
- Introduce GH API helper tests
- Improve overall test coverage
Member
Author
|
Follow-up for #356 |
Member
|
@snazy When you pick this back up, could you rebase onto latest |
6d3c42b to
ce8e53d
Compare
potiuk
approved these changes
Jun 11, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
Great follow-up. Addresses 4 of the 5 nits from #356 — json.loads for API bodies, exact-tag matching that drops prefix-matched siblings, the wildcard + untagged-SHA ordering fix, and the typo — each with a regression test (test_matching_tag_prefix_results_do_not_satisfy_shorter_tag, test_wildcard_after_untagged_sha_records_mixed_ref_warning). Live API calls are now mocked, with the real ones gated behind GH_TOKEN. 36 tests, all green. LGTM — thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.