Fix DatePatternConverter locale parsing when timezone is omitted#4130
Open
ramanathan1504 wants to merge 2 commits into
Open
Fix DatePatternConverter locale parsing when timezone is omitted#4130ramanathan1504 wants to merge 2 commits into
ramanathan1504 wants to merge 2 commits into
Conversation
| private static final Set<String> UPPERCASE_TIME_ZONE_IDS = AVAILABLE_TIME_ZONE_IDS.stream() | ||
| .map(id -> id.toUpperCase(Locale.ROOT)) | ||
| .collect(Collectors.toSet()); | ||
| private static final String LOCALE_LANGUAGE_ONLY_PATTERN = "[a-zA-Z]{2}"; |
There was a problem hiding this comment.
these could be a Pattern instead, to avoid recompiling it on every String.matches call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4129
DatePatternConverter incorrectly interpreted locale-like second arguments (for example de-DE) as timezone IDs when no timezone was provided.
This caused patterns like %d{dd-MMMM-yyyy}{de-DE} to use the JVM default locale instead of the requested locale, producing incorrect localized month names.
This change tightens locale detection so locale tags are correctly recognized in the 2-argument form, while preserving existing behavior for the 3-argument form %d{pattern}{timezone}{locale}.