Skip to content

test(bitbucket): pin redirect rejection for authenticated requests #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KatalKavya96 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(bitbucket): pin redirect rejection for authenticated requests #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion tools/bitbucket/tests/test_bitbucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@

from magpie_bitbucket import cloud, datacenter
from magpie_bitbucket.cli import main
from magpie_bitbucket.client import BitbucketError, SameHostRedirectHandler, load_config, make_auth_header
from magpie_bitbucket.client import (
BitbucketError,
NoAuthRedirectHandler,
SameHostRedirectHandler,
load_config,
make_auth_header,
)
from magpie_bitbucket.normalize import (
created_issue_comment,
issue,
Expand Down Expand Up @@ -106,6 +112,24 @@ def urllib_request(url: str) -> urllib.request.Request:
)


def test_no_auth_redirect_handler_rejects_redirect() -> None:
handler = NoAuthRedirectHandler()
request = urllib_request("https://api.bitbucket.org/2.0/repositories/apache/magpie")

with pytest.raises(
BitbucketError,
match="refusing to forward credentials",
):
handler.redirect_request(
request,
None,
302,
"Found",
{},
"https://api.bitbucket.org/2.0/repositories/apache/magpie/issues/7/comments",
)


def test_same_host_redirect_handler_allows_same_origin() -> None:
handler = SameHostRedirectHandler()
request = urllib_request("https://bitbucket.example.test/rest/api/1.0/foo")
Expand Down
Loading