Skip to content

Port the IT scripts from BeanShell to Groovy - #1378

Merged
slachiewicz merged 2 commits into
masterfrom
agent/bsh-to-groovy
Sep 20, 2026
Merged

slachiewicz merged 2 commits into
masterfrom
agent/bsh-to-groovy

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

Ports the 108 BeanShell IT scripts under src/it/projects to Groovy, keeping the same checks. 101 were already valid Groovy. The seven that changed: two dead printlns of a variable no script ever declared (BeanShell treats an unbound name as void, Groovy throws) are removed (basic-features/add-classpath, mojo-configuration/manifest-with-customEntry-manifest-file); a same-scope String line redeclaration becomes an assignment (metaInf-spring-aggregation); a File[] x = { … } initialiser becomes a list literal (dep-transfilter-wildcard-massembly544); two literal ${…} assertions use single quotes so Groovy does not interpolate them (filters-defined-in-build, massembly-285-assembly); and BeanShell's basedir == void unset check becomes !binding.hasVariable('basedir') (dependencySet-projectArtifactNotIncluded). The rename is a separate commit so the port reads as a diff. Part of apache/maven#13207.

Three of the scripts never run under -Prun-its and are ported blind: two are submodules no pomInclude matches (massembly-285-assembly, multimodule-filteredFileSet/child) and depSet-transFromProfile is in pomExcludes.

Verified: mvn verify -Prun-its -Dinvoker.test=<all 105 runnable IT projects> in five batches → 26 + 26 + 26 + 26 + 6 passed, 0 failed (each batch includes the it-project-parent setup project).

@slachiewicz
slachiewicz marked this pull request as ready for review September 20, 2026 13:11
@slachiewicz
slachiewicz merged commit 53cb90a into master Sep 20, 2026
21 checks passed
@slachiewicz
slachiewicz deleted the agent/bsh-to-groovy branch September 20, 2026 13:48
@github-actions github-actions Bot added this to the 3.8.1 milestone Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant