[MDEP-858] Replace Maven Artifact Transfer with Maven Resolver

pom.xml

@@ -148,13 +148,6 @@ under the License.
       <version>${mavenVersion}</version>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>org.apache.maven</groupId>
-      <artifactId>maven-settings</artifactId>
-      <version>${mavenVersion}</version>
-      <scope>provided</scope>
-    </dependency>
-
     <!-- domtrip -->
     <dependency>
       <groupId>eu.maveniverse.maven.domtrip</groupId>
@@ -238,21 +231,6 @@ under the License.
       <artifactId>maven-common-artifact-filters</artifactId>
       <version>3.4.0</version>
     </dependency>
-    <dependency>
-      <groupId>org.apache.maven.shared</groupId>
-      <artifactId>maven-artifact-transfer</artifactId>
-      <version>0.13.1</version>
-      <exclusions>
-        <exclusion>
-          <groupId>org.apache.maven</groupId>
-          <artifactId>maven-artifact</artifactId>
-        </exclusion>
-        <exclusion>
-          <groupId>org.apache.maven</groupId>
-          <artifactId>maven-core</artifactId>
-        </exclusion>
-      </exclusions>
-    </dependency>
     <dependency>
       <groupId>org.apache.maven.shared</groupId>
       <artifactId>maven-shared-utils</artifactId>
@@ -396,6 +374,7 @@ under the License.
       <version>${jettyVersion}</version>
       <scope>test</scope>
     </dependency>
+
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>

src/it/projects/purge-local-repository-bad-dep/pom.xml

@@ -43,5 +43,11 @@
       <artifactId>purge-local-repository</artifactId>
       <version>1.0</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven</groupId>
+      <artifactId>maven-model</artifactId>
+      <version>2.0.9</version>
+      <classifier>sources</classifier>
+    </dependency>
   </dependencies>
 </project>

src/it/projects/purge-local-repository-bad-dep/verify.groovy

@@ -28,10 +28,13 @@ void checkFilePresence( String path )
 
 checkFilePresence( "org/apache/maven/its/dependency/purge-local-repository/1.0/purge-local-repository-1.0.jar" )
 checkFilePresence( "org/apache/maven/its/dependency/purge-local-repository/1.0/purge-local-repository-1.0.pom" )
+checkFilePresence( "org/apache/maven/maven-model/2.0.9/maven-model-2.0.9-sources.jar" )
 
 String buildLog = new File( basedir, "build.log" ).getText( "UTF-8" )
 assert buildLog.contains( 'Unable to resolve artifact: org.apache.maven.its.dependency:i-do-not-exist:jar:1.0' )
 assert buildLog.contains( 'Purging artifact: org.apache.maven.its.dependency:purge-local-repository:jar:1.0' )
 assert buildLog.contains( 'Resolving artifact: org.apache.maven.its.dependency:purge-local-repository:jar:1.0' )
+assert buildLog.contains( 'Purging artifact: org.apache.maven:maven-model:jar:sources:2.0.9' )
+assert buildLog.contains( 'Resolving artifact: org.apache.maven:maven-model:jar:sources:2.0.9' )
 
 return true

src/it/projects/purge-local-repository/pom.xml

@@ -42,6 +42,18 @@
       <artifactId>purged</artifactId>
       <version>1.0</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven.its.dependency</groupId>
+      <artifactId>not-purged-test</artifactId>
+      <version>1.0</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.maven.its.dependency</groupId>
+      <artifactId>not-purged-provided</artifactId>
+      <version>1.0</version>
+      <scope>provided</scope>
+    </dependency>
   </dependencies>
 
 </project>

src/it/projects/purge-local-repository/setup.bsh

@@ -19,9 +19,42 @@
 
 import java.io.*;
 
-File purgedJar = new File( localRepositoryPath, "org/apache/maven/its/dependency/purged/1.0/purged-1.0.jar" );
+void createJar( String artifactId )
+{
+    File jar = new File( localRepositoryPath,
+            "org/apache/maven/its/dependency/" + artifactId + "/1.0/" + artifactId + "-1.0.jar" );
+    jar.getParentFile().mkdirs();
+    jar.createNewFile();
+}
 
-purgedJar.getParentFile().mkdirs();
-purgedJar.createNewFile();
+createJar( "purged" );
+createJar( "not-purged-test" );
+createJar( "not-purged-provided" );
+createJar( "not-purged-optional" );
+
+File purgedPom = new File( localRepositoryPath,
+        "org/apache/maven/its/dependency/purged/1.0/purged-1.0.pom" );
+PrintWriter writer = new PrintWriter( purgedPom, "UTF-8" );
+try
+{
+    writer.println( "<project>" );
+    writer.println( "  <modelVersion>4.0.0</modelVersion>" );
+    writer.println( "  <groupId>org.apache.maven.its.dependency</groupId>" );
+    writer.println( "  <artifactId>purged</artifactId>" );
+    writer.println( "  <version>1.0</version>" );
+    writer.println( "  <dependencies>" );
+    writer.println( "    <dependency>" );
+    writer.println( "      <groupId>org.apache.maven.its.dependency</groupId>" );
+    writer.println( "      <artifactId>not-purged-optional</artifactId>" );
+    writer.println( "      <version>1.0</version>" );
+    writer.println( "      <optional>true</optional>" );
+    writer.println( "    </dependency>" );
+    writer.println( "  </dependencies>" );
+    writer.println( "</project>" );
+}
+finally
+{
+    writer.close();
+}
 
 return true;

src/it/projects/purge-local-repository/verify.groovy

@@ -26,7 +26,19 @@ void checkFileAbsence( String path )
   }
 }
 
+void checkFilePresence( String path )
+{
+  File depJar = new File( localRepositoryPath, path )
+  if ( !depJar.exists() )
+  {
+    throw new Exception( "Dependency jar was purged: " + depJar )
+  }
+}
+
 checkFileAbsence( "org/apache/maven/its/dependency/purged/1.0/purged-1.0.jar" )
+checkFilePresence( "org/apache/maven/its/dependency/not-purged-test/1.0/not-purged-test-1.0.jar" )
+checkFilePresence( "org/apache/maven/its/dependency/not-purged-provided/1.0/not-purged-provided-1.0.jar" )
+checkFilePresence( "org/apache/maven/its/dependency/not-purged-optional/1.0/not-purged-optional-1.0.jar" )
 
 String buildLog = new File( basedir, "build.log" ).getText( "UTF-8" )
 assert buildLog.contains( 'Deleting 1 transitive dependency for project test from ' )