nimble/host: Initialize att_len in ble_att_svr_service_uuid#2221
Merged
sjanc merged 1 commit intoapache:masterfrom May 7, 2026
Merged
nimble/host: Initialize att_len in ble_att_svr_service_uuid#2221sjanc merged 1 commit intoapache:masterfrom
sjanc merged 1 commit intoapache:masterfrom
Conversation
MariuszSkamra
approved these changes
May 4, 2026
This is false positive as apparently some compilers don't handle
rc and attr_len correlation correctly.
In function 'ble_att_svr_service_uuid',
inlined from 'ble_att_svr_build_read_group_type_rsp' at nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:1956:22,
inlined from 'ble_att_svr_rx_read_group_type' at nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:2101:10:
nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:1833:10: warning: 'attr_len' may be used uninitialized [-Wmaybe-uninitialized]
1833 | rc = ble_uuid_init_from_buf(uuid, val, attr_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c: In function 'ble_att_svr_rx_read_group_type':
nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:1824:14: note: 'attr_len' was declared here
1824 | uint16_t attr_len;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is false positive as apparently some compilers doesn't handle rc and attr_len correlation correctly.
In function 'ble_att_svr_service_uuid',
inlined from 'ble_att_svr_build_read_group_type_rsp' at nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:1956:22,
inlined from 'ble_att_svr_rx_read_group_type' at nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:2101:10:
nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:1833:10: warning: 'attr_len' may be used uninitialized [-Wmaybe-uninitialized]
1833 | rc = ble_uuid_init_from_buf(uuid, val, attr_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c: In function 'ble_att_svr_rx_read_group_type':
nimble/mynewt-nimble/nimble/host/src/ble_att_svr.c:1824:14: note: 'attr_len' was declared here
1824 | uint16_t attr_len;