nimble/ll/test: Refactor ISO tests and implement test fixtures#2223
Open
MariuszSkamra wants to merge 1 commit intoapache:masterfrom
Open
nimble/ll/test: Refactor ISO tests and implement test fixtures#2223MariuszSkamra wants to merge 1 commit intoapache:masterfrom
MariuszSkamra wants to merge 1 commit intoapache:masterfrom
Conversation
This refactors the ISO test suite by introducing a dedicated test fixture, which ensures a clean state for every individual test case. By automating the reset process, we reduce boilerplate code and make the suite significantly easier to maintain and extend. Additionally, the ISO test buffer size has been re-evaluated and adjusted to properly accommodate both the payload data and the required ISO headers, preventing potential buffer overflows during testing.
sjanc
reviewed
May 7, 2026
|
|
||
| for (i = 0; i < sizeof os_mbuf_test_data; i++) { | ||
| os_mbuf_test_data[i] = i; | ||
| for (i = 0; i < sizeof g_test_sdu_data; i++) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the ISO test suite by introducing a dedicated test fixture, which ensures a clean state for every individual test case. By automating the reset process, we reduce boilerplate code and make the suite significantly easier to maintain and extend.
Additionally, the ISO test buffer size has been re-evaluated and adjusted to properly accommodate both the payload data and the required ISO headers, preventing potential buffer overflows during testing.