NIFI-16368 Improve validation for Parameter Context ID values - #11695
Merged
Merged
Conversation
pvillard31
reviewed
Sep 18, 2026
| } | ||
| } | ||
|
|
||
| private void verifyParameterContextId(final String pathId, final String requestId) { |
Contributor
There was a problem hiding this comment.
Should submitParameterContextUpdate also use this helper so all three endpoints apply the same validation and error messages?
Contributor
Author
|
Thanks @pvillard31, although that method was already checking the values, I agree it makes sense to reuse the new method. |
pvillard31
approved these changes
Sep 18, 2026
pvillard31
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will merge once the checks are green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16368 Improves input validation for Parameter Context identifiers provided through URL and request entity fields in REST Resource methods.
Changes include a new shared private method for identifier validation and comparison, along with unit test updates to verify expected validation behavior.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation