build: fix sbt lint warnings by excluding unused keys#1071
Merged
Conversation
Motivation: sbt lint reported 45 unused keys across sub-projects. Modification: Add projectInfoVersion, mimaReportSignatureProblems, autoAPIMappings, and unidocProjectFilter to excludeLintKeys in project/Common.scala globalSettings. Result: sbt lint warnings resolved. Tests: - sbt "http-core / compile; http / compile; parsing / compile" - sbt lint warnings resolved - sbt "http-caching / compile; http-cors / compile; http-testkit / compile" - sbt lint warnings resolved References: None - build configuration cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sbt lint reported 45 unused keys (
projectInfoVersion,mimaReportSignatureProblems,autoAPIMappings,unidocProjectFilter) across sub-projects. These keys are intentionally set inCommon.scalaandDoc.scalaplugins withallRequirementstrigger but are only read in specific scopes, causing spurious lint warnings.Modification
Add
projectInfoVersion,mimaReportSignatureProblems,autoAPIMappings, andunidocProjectFiltertoexcludeLintKeysinproject/Common.scalaglobalSettings.Result
All 45 sbt lint warnings resolved with a single centralized exclusion in the common plugin.
Tests
sbt "http-core / compile; http / compile; parsing / compile"- no sbt lint warningssbt "http-caching / compile; http-cors / compile; http-testkit / compile; http-marshallers-scala / compile; http-marshallers-java / compile"- no sbt lint warningsReferences
None - build configuration cleanup