refactor: modernize Java test code with Java 17 features#1076
Merged
He-Pin merged 1 commit intoJun 18, 2026
Conversation
Motivation: Java 17 introduced records and text blocks that make Java code more concise and readable. Modification: - Convert SomeData to a record in both Jackson and Jackson3 test modules - Convert Bid, GetBids, Bids to records in HttpServerActorInteractionExample - Use text blocks for multi-line config strings in Jackson tests - Update field accesses to use record accessor methods Result: Test Java code is more concise and idiomatic for Java 17+. Tests: sbt "http-marshallers-java/http-jackson / Test / compile" sbt "http-marshallers-java/http-jackson3 / Test / compile" sbt "docs / Test / compile" References: None - code modernization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Java 17 introduced records and text blocks that make Java code more concise and readable.
Modification
Result
Test Java code is more concise and idiomatic for Java 17+, reducing boilerplate.
Tests
sbt "http-marshallers-java/http-jackson / Test / compile"(to be verified by CI)sbt "http-marshallers-java/http-jackson3 / Test / compile"(to be verified by CI)sbt "docs / Test / compile"(to be verified by CI)References
None - code modernization