Skip to content

[BugFix] Handling NPE in VarianceAggregationFunction merger #15909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jitendrakr88 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BugFix] Handling NPE in VarianceAggregationFunction merger #15909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...in/java/org/apache/pinot/core/query/aggregation/function/VarianceAggregationFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,10 @@ public VarianceTuple extractGroupByResult(GroupByResultHolder groupByResultHolde

@Override
public VarianceTuple merge(VarianceTuple intermediateResult1, VarianceTuple intermediateResult2) {
if (_nullHandlingEnabled) {
if (intermediateResult1 == null) {
return intermediateResult2;
} else if (intermediateResult2 == null) {
return intermediateResult1;
}
if (intermediateResult1 == null) {
return intermediateResult2;
} else if (intermediateResult2 == null) {
return intermediateResult1;
}
intermediateResult1.apply(intermediateResult2);
return intermediateResult1;
Expand Down