Skip to content

fix: add column-type precondition check in isFitForNonScanBasedPlan for MINLONG/MAXLONG/MINSTRING/MAXSTRING #19146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add column-type precondition check in isFitForNonScanBasedPlan for MINLONG/MAXLONG/MINSTRING/MAXSTRING #19146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.apache.pinot.segment.spi.SegmentContext;
import org.apache.pinot.segment.spi.datasource.DataSource;
import org.apache.pinot.segment.spi.index.reader.NullValueVectorReader;
import org.apache.pinot.spi.data.FieldSpec;

import static org.apache.pinot.segment.spi.AggregationFunctionType.*;

Expand Down Expand Up @@ -179,6 +180,25 @@ private boolean isFitForNonScanBasedPlan() {
}
DataSource dataSource = _indexSegment.getDataSource(argument.getIdentifier(), _queryContext.getSchema());
if (DICTIONARY_BASED_FUNCTIONS.contains(aggregationFunction.getType())) {
// MINLONG/MAXLONG can only be resolved from dictionary for INT/LONG columns, because the resolver
// (getMinValueLong/getMaxValueLong) requires an integer stored type.
AggregationFunctionType functionType = aggregationFunction.getType();
if (functionType == MINLONG || functionType == MAXLONG) {
FieldSpec.DataType storedType =
dataSource.getDataSourceMetadata().getDataType().getStoredType();
if (storedType != FieldSpec.DataType.INT && storedType != FieldSpec.DataType.LONG) {
return false;
}
}
// MINSTRING/MAXSTRING can only be resolved from dictionary for STRING columns, because the
// function rejects numeric columns on the scan path.
if (functionType == MINSTRING || functionType == MAXSTRING) {
FieldSpec.DataType storedType =
dataSource.getDataSourceMetadata().getDataType().getStoredType();
if (storedType != FieldSpec.DataType.STRING) {
return false;
}
}
if (dataSource.getDictionary() != null) {
continue;
}
Expand Down