Remove stray blank line in CaseTransformFunction - #19198
Closed
xiangfu0 wants to merge 1 commit into
Closed
Conversation
Follow-up to a review comment on apache#18872. The double blank line was introduced by apache#19183 rather than removed by it. Checkstyle does not catch it: the RegexpMultiline rule only covers a blank line before a closing brace, not a double blank line between methods.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19198 +/- ##
============================================
- Coverage 66.65% 66.64% -0.02%
Complexity 1423 1423
============================================
Files 3443 3443
Lines 218663 218663
Branches 34801 34801
============================================
- Hits 145750 145726 -24
- Misses 61192 61211 +19
- Partials 11721 11726 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18872 (comment), where @Jackie-Jiang asked for this line to be removed. It was not removed — #19183 actually introduced it.
On master today:
Checkstyle does not flag it: the
RegexpMultilinerule inconfig/checkstyle.xmlmatches a blank line before a closing brace, not a double blank line between methods.Whitespace only — no behavior change.