[ISSUE #54 #50] Operator multiple mq cluster && start sequence - #56
[ISSUE #54 #50] Operator multiple mq cluster && start sequence#56linjiemiao wants to merge 2 commits into
Conversation
linjiemiao
commented
Sep 22, 2020
- ensure rocketmq-operator can operator more than one rocketmq cluster;
- make sure nameserver must ready before broker cluster.
2. make sure nameserver must ready before broker cluster.
| size: 1 | ||
| # nameServers is the [ip:port] list of name service | ||
| nameServers: "" | ||
| # rocketMQName is the rocketmq name, must equal to nameserver.spec.rocketMQName and topictransfer.spec.rocketMQName |
There was a problem hiding this comment.
We can not ensure users set insistent name correctly, is there a better way to do this?
There was a problem hiding this comment.
I did this because we don't have a rocketmq resource as the parent resource of the broker and nameserver. Without a common parent controller, we can only specify the connection of the child resource in the spec. So I hope to add a rocketmq api.
There was a problem hiding this comment.
In that case should we add rocketmq higher level api before this PR?
|
still need this |
|
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts: git fetch origin
git checkout issue-54-codereview
git rebase origin/main
# resolve conflicts, then:
git push --force-with-leaseThis is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved. Automated notification by github-manager-bot |