Skip to content

[ISSUE #10762] Avoid exposing RemoteChannel extend attribute #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aias00 wants to merge 2 commits into
base: develop
Choose a base branch
from
+24 −2
Open

[ISSUE #10762] Avoid exposing RemoteChannel extend attribute #10763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b8fd4
[ISSUE #10762] Avoid exposing RemoteChannel extend attribute
Aias00 Aug 3, 2026
09883c2
fix(proxy): snapshot remote channel metadata in logs
Aias00 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion proxy/src/main/java/org/apache/rocketmq/proxy/processor/channel/RemoteChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,13 @@ public String getChannelExtendAttribute() {

@Override
public String toString() {
String extendAttributeSnapshot = this.extendAttribute;
return MoreObjects.toStringHelper(this)
.add("channelId", id())
.add("type", type)
.add("remoteProxyIp", remoteProxyIp)
.add("extendAttribute", extendAttribute)
.add("extendAttributePresent", extendAttributeSnapshot != null)
.add("extendAttributeLength", extendAttributeSnapshot == null ? 0 : extendAttributeSnapshot.length())
.toString();
}
}
22 changes: 21 additions & 1 deletion proxy/src/test/java/org/apache/rocketmq/proxy/processor/channel/RemoteChannelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@
import org.junit.Test;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;

public class RemoteChannelTest {

Expand All @@ -47,4 +49,22 @@ public void testEncodeAndDecode() {

assertNull(RemoteChannel.decode(""));
}
}

@Test
public void testToStringDoesNotExposeExtendAttribute() {
String extendAttribute = "sensitive-client-settings";
RemoteChannel remoteChannel = new RemoteChannel(
"11.193.0.1",
"10.152.39.53:9768",
"11.193.0.1:1210",
ChannelProtocolType.GRPC_V2,
extendAttribute
);

String output = remoteChannel.toString();

assertFalse(output.contains(extendAttribute));
assertTrue(output.contains("extendAttributePresent=true"));
assertTrue(output.contains("extendAttributeLength=" + extendAttribute.length()));
}
}
Loading