Skip to content

[ISSUE #10776] Handle short HTTP2 protocol buffers #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aias00 wants to merge 2 commits into
base: develop
Choose a base branch
from
+35 −2
Open

[ISSUE #10776] Handle short HTTP2 protocol buffers #10777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d9f063
[ISSUE #10776] Handle short HTTP2 protocol buffers
Aias00 Aug 3, 2026
f5a345d
test(proxy): isolate http2 protocol handler config
Aias00 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ava/org/apache/rocketmq/proxy/remoting/protocol/http2proxy/Http2ProtocolProxyHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ public boolean match(ByteBuf in) {
if (!ConfigurationManager.getProxyConfig().isEnableRemotingLocalProxyGrpc()) {
return false;
}
if (in.readableBytes() < Integer.BYTES) {
return false;
}

// If starts with 'PRI '
return in.getInt(in.readerIndex()) == PRI_INT;
Expand Down
34 changes: 32 additions & 2 deletions ...org/apache/rocketmq/proxy/remoting/protocol/http2proxy/Http2ProtocolProxyHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,30 @@

package org.apache.rocketmq.proxy.remoting.protocol.http2proxy;

import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import io.netty.channel.Channel;
import io.netty.channel.ChannelPipeline;
import io.netty.handler.codec.haproxy.HAProxyMessageEncoder;
import org.apache.rocketmq.proxy.config.ConfigurationManager;
import org.apache.rocketmq.proxy.config.InitConfigTest;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;

import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;

@RunWith(MockitoJUnitRunner.class)
public class Http2ProtocolProxyHandlerTest {
public class Http2ProtocolProxyHandlerTest extends InitConfigTest {

private Http2ProtocolProxyHandler http2ProtocolProxyHandler;
private boolean originalEnableRemotingLocalProxyGrpc;
@Mock
private Channel inboundChannel;
@Mock
Expand All @@ -44,9 +52,16 @@ public class Http2ProtocolProxyHandlerTest {

@Before
public void setUp() throws Exception {
originalEnableRemotingLocalProxyGrpc = ConfigurationManager.getProxyConfig().isEnableRemotingLocalProxyGrpc();
ConfigurationManager.getProxyConfig().setEnableRemotingLocalProxyGrpc(true);
http2ProtocolProxyHandler = new Http2ProtocolProxyHandler();
Comment on lines 53 to 57
}

@After
public void tearDown() {
ConfigurationManager.getProxyConfig().setEnableRemotingLocalProxyGrpc(originalEnableRemotingLocalProxyGrpc);
}

@Test
public void configPipeline() {
when(inboundChannel.pipeline()).thenReturn(inboundPipeline);
Expand All @@ -55,4 +70,19 @@ public void configPipeline() {
when(outboundPipeline.addFirst(any(HAProxyMessageEncoder.class))).thenReturn(outboundPipeline);
http2ProtocolProxyHandler.configPipeline(inboundChannel, outboundChannel);
}
}

@Test
public void matchReturnsFalseForShortBuffers() {
assertFalse(http2ProtocolProxyHandler.match(Unpooled.EMPTY_BUFFER));

ByteBuf shortBuffer = Unpooled.wrappedBuffer(new byte[] {'P', 'R', 'I'});
assertFalse(http2ProtocolProxyHandler.match(shortBuffer));
}

@Test
public void matchReturnsTrueForHttp2PrefacePrefix() {
ByteBuf http2Prefix = Unpooled.wrappedBuffer(new byte[] {'P', 'R', 'I', ' '});

assertTrue(http2ProtocolProxyHandler.match(http2Prefix));
}
}
Loading