Skip to content

[ISSUE #10801] Surface unexpected topic route lookup errors #10802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aias00 wants to merge 2 commits into
base: develop
Choose a base branch
from
+30 −3
Open

[ISSUE #10801] Surface unexpected topic route lookup errors #10802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcdb36
fix(proxy): surface unexpected topic route lookup errors
Aias00 Aug 3, 2026
c0fac7f
test(proxy): retain topic route lookup failure context
Aias00 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions proxy/src/main/java/org/apache/rocketmq/proxy/service/admin/DefaultAdminService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,12 @@ public boolean topicExist(String topic) {
try {
topicRouteData = this.getTopicRouteDataDirectlyFromNameServer(topic);
topicExist = topicRouteData != null;
} catch (Throwable e) {
topicExist = false;
} catch (Exception e) {
if (TopicRouteHelper.isTopicNotExistError(e)) {
topicExist = false;
} else {
throw new IllegalStateException("get topic route for topic='" + topic + "' failed", e);
}
}

return topicExist;
Expand Down
25 changes: 24 additions & 1 deletion proxy/src/test/java/org/apache/rocketmq/proxy/service/admin/DefaultAdminServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.rocketmq.remoting.protocol.route.TopicRouteData;
import org.apache.rocketmq.client.impl.mqclient.MQClientAPIExt;
import org.apache.rocketmq.client.impl.mqclient.MQClientAPIFactory;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand All @@ -35,6 +36,7 @@
import org.mockito.junit.MockitoJUnitRunner;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.anyString;
Expand Down Expand Up @@ -87,6 +89,27 @@ public void testCreateTopic() throws Exception {
assertEquals(8, topicConfigArgumentCaptor.getValue().getReadQueueNums());
}

@Test
public void testTopicExistReturnsFalseForNotFound() throws Exception {
when(mqClientAPIExt.getTopicRouteInfoFromNameServer(eq("missingTopic"), anyLong()))
.thenThrow(new MQClientException(ResponseCode.TOPIC_NOT_EXIST, "topic not exist"));

assertFalse(defaultAdminService.topicExist("missingTopic"));
}

@Test
public void testTopicExistThrowsForUnexpectedRouteLookupFailure() throws Exception {
MQClientException cause = new MQClientException(ResponseCode.SYSTEM_ERROR, "namesrv unavailable");
when(mqClientAPIExt.getTopicRouteInfoFromNameServer(eq("brokenTopic"), anyLong()))
.thenThrow(cause);

IllegalStateException exception = Assert.assertThrows(IllegalStateException.class,
() -> defaultAdminService.topicExist("brokenTopic"));

assertEquals("get topic route for topic='brokenTopic' failed", exception.getMessage());
assertEquals(cause, exception.getCause());
}

private TopicRouteData createTopicRouteData(int brokerNum) {
TopicRouteData topicRouteData = new TopicRouteData();
for (int i = 0; i < brokerNum; i++) {
Expand All @@ -100,4 +123,4 @@ private TopicRouteData createTopicRouteData(int brokerNum) {
}
return topicRouteData;
}
}
}
Loading