Skip to content

[ISSUE #10806] Log proxy remoting cleanup failures - #10807

Open
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/proxy-remoting-cleanup-exception-10806
Open

[ISSUE #10806] Log proxy remoting cleanup failures#10807
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/proxy-remoting-cleanup-exception-10806

Conversation

@Aias00

@Aias00 Aias00 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • log unexpected failures from Proxy remoting expired request cleanup with compact queue context
  • stop the current cleanup pass after such failures to avoid silent loop churn
  • add regression coverage for queue access failures

Tests

  • JAVA_HOME=$(/usr/libexec/java_home -v 1.8) mvn -pl proxy -DskipITs -DskipCheckStyle -Dtest=RemotingProtocolServerTest test
  • git diff --check

Closes #10806

Copilot AI review requested due to automatic review settings August 4, 2026 00:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Proxy remoting expired-request queue cleanup to avoid silently swallowing unexpected failures by logging a warning with compact queue context and breaking out of the current cleanup pass. It also adds a regression test to ensure the cleanup does not spin when queue access fails.

Changes:

  • Log unexpected exceptions during cleanExpiredRequestInQueue with queue size context and stop the current cleanup pass.
  • Add safeQueueSize(...) helper to safely obtain queue size for logging.
  • Add a regression unit test covering queue access failure behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
proxy/src/main/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServer.java Logs cleanup failures with queue context and breaks the cleanup loop to prevent silent churn.
proxy/src/test/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServerTest.java Adds regression coverage ensuring cleanup stops promptly when getQueue() throws.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.23%. Comparing base (eddb235) to head (1536de3).

Files with missing lines Patch % Lines
...ocketmq/proxy/remoting/RemotingProtocolServer.java 60.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10807      +/-   ##
=============================================
- Coverage      48.33%   48.23%   -0.10%     
+ Complexity     13524    13488      -36     
=============================================
  Files           1380     1380              
  Lines         101104   101113       +9     
  Branches       13107    13108       +1     
=============================================
- Hits           48864    48772      -92     
- Misses         46281    46355      +74     
- Partials        5959     5986      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Proxy remoting expired request cleanup silently swallows exceptions

3 participants