[ISSUE #10808] Tolerate proxy delay level whitespace - #10809
Open
Aias00 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10809 +/- ##
=============================================
- Coverage 48.33% 48.23% -0.10%
+ Complexity 13524 13493 -31
=============================================
Files 1380 1380
Lines 101104 101107 +3
Branches 13107 13108 +1
=============================================
- Hits 48864 48769 -95
- Misses 46281 46359 +78
- Partials 5959 5979 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
messageDelayLevelwith trimmed\s+tokens instead of splitting only on a single space.useDelayLeveldoes not later read an empty table.ProxyConfigTestcoverage for repeated whitespace and blank config values.Why
messageDelayLevelis a config-file value. Repeated spaces, tabs, newlines, or blank input should not leave Proxy delay-level parsing partially populated or empty.Validation
JAVA_HOME=$(/usr/libexec/java_home -v 1.8) mvn -pl proxy -DskipITs -DskipCheckStyle -Dtest=ProxyConfigTest testgit diff --checkCloses #10808