Skip to content

[ISSUE #10835] fix(common): reject malformed topic config atomically - #10845

Open
yuluo-yx wants to merge 1 commit into
apache:developfrom
yuluo-yx:0808-yuluo/fix-7
Open

[ISSUE #10835] fix(common): reject malformed topic config atomically#10845
yuluo-yx wants to merge 1 commit into
apache:developfrom
yuluo-yx:0808-yuluo/fix-7

Conversation

@yuluo-yx

@yuluo-yx yuluo-yx commented Aug 8, 2026

Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Brief Description

Parse mandatory topic configuration fields before assignment so malformed input returns false without partially mutating the object.

How Did You Test This Change?

  • mise x java@temurin-17 -- mvn -pl common -Dtest=TopicConfigTest test

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.32%. Comparing base (fd0c959) to head (8dc1937).

Files with missing lines Patch % Lines
...n/java/org/apache/rocketmq/common/TopicConfig.java 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10845      +/-   ##
=============================================
- Coverage      48.37%   48.32%   -0.05%     
+ Complexity     13555    13535      -20     
=============================================
  Files           1380     1380              
  Lines         101165   101172       +7     
  Branches       13127    13127              
=============================================
- Hits           48940    48893      -47     
- Misses         46250    46287      +37     
- Partials        5975     5992      +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good atomic-decode pattern — parsing all fields into local variables first and only assigning to instance fields after full validation prevents partially-updated config state. The NumberFormatException handling for readQueueNums / writeQueueNums is correct.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TopicConfig.decode mutates state or throws for malformed config

3 participants