[ISSUE #10861] Validate controller broker IDs eagerly - #10866
Open
yuluo-yx wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Aug 8, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fixes a validation bypass where Arrays.stream(...).map(Long::parseLong) created a lazy stream that was never consumed (no terminal operation), so Long.parseLong was never called and invalid broker IDs passed silently.
Analysis
- Correctness ✅ — The old code was a classic Java Streams pitfall: creating a stream pipeline without a terminal operation means nothing executes. Replacing with an eager
forloop is the right fix — simpler and guaranteed to execute. - Tests ✅ — Regression test verifies that an invalid ID now throws
NumberFormatException. - Performance ✅ — For a small list of broker IDs, a simple for loop is more efficient than stream creation overhead.
- Compatibility ✅ — No API changes; strictly adds validation that should have been there.
LGTM.
Automated review by github-manager-bot
Member
Author
|
I confirmed the CI failure is not caused by this PR. Please rerun CI, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
CleanControllerBrokerMetaSubCommandbuilt a lazy stream to parse controller broker IDs but never consumed it, so invalid values were not validated. This change eagerly parses every semicolon-separated ID before any admin request.A regression test supplies
1;not-a-numberand verifies that command execution rejects it withIllegalArgumentException.How Did You Test This Change?
mise exec java@temurin-17.0.19+10 -- mvn -pl tools -am -DskipITs -Dtest=CleanControllerBrokerMetaSubCommandTest -Dsurefire.failIfNoSpecifiedTests=false -Dspotbugs.skip=true testBUILD SUCCESS; 1 test, 0 failures, 0 errors, 0 skipped.