[ISSUE #10862] Accept zero floating-point filter literals - #10867
Open
yuluo-yx wants to merge 1 commit into
Open
[ISSUE #10862] Accept zero floating-point filter literals#10867yuluo-yx wants to merge 1 commit into
yuluo-yx wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Aug 8, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Fixes a bug where ConstantExpression.createFloat rejected 0.0 (and all negative values) because Double.MIN_VALUE is the smallest positive double (4.9E-324), not the most negative. The lower bound is corrected to -Double.MAX_VALUE.
Analysis
- Correctness ✅ —
Double.MIN_VALUEas a lower bound was clearly wrong. The fix to-Double.MAX_VALUEcorrectly allows the full range of finite doubles including zero and negatives. - Tests ✅ — Regression test covers
a = 0.0which was the failing case. - Compatibility ✅ — Widens accepted range; no breaking change for existing valid inputs.
LGTM.
Automated review by github-manager-bot
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10867 +/- ##
=============================================
- Coverage 48.39% 48.30% -0.10%
+ Complexity 13562 13527 -35
=============================================
Files 1380 1380
Lines 101165 101165
Branches 13127 13127
=============================================
- Hits 48962 48864 -98
- Misses 46233 46306 +73
- Partials 5970 5995 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
ConstantExpression.createFloatusedDouble.MIN_VALUE, the smallest positive value, as a lower bound and therefore rejected0.0. This change uses-Double.MAX_VALUEas the finite lower bound.A selector regression test verifies that
a = 0.0parses and evaluates successfully.How Did You Test This Change?
mise exec java@temurin-17.0.19+10 -- mvn -pl filter -am -DskipITs -Dtest=ExpressionTest -Dsurefire.failIfNoSpecifiedTests=false testBUILD SUCCESS; 62 tests, 0 failures, 0 errors, 0 skipped.