[ISSUE-10861] Fix brokerControllerIdsToClean validation not actually parsing IDs

[YALI58]

Bug Description

cleanBrokerMetadata command uses Arrays.stream(...).map(Long::parseLong) to validate broker controller IDs. Since map() is a lazy intermediate operation without a terminal operation, Long.parseLong() is never executed, allowing malformed IDs like not-a-number to pass validation.

Fix

Changed map() to forEach() so the stream is actually consumed and Long.parseLong() is evaluated for each ID.

Testing

Added CleanControllerBrokerMetaSubCommandTest with a test case that verifies malformed input throws IllegalArgumentException.

Closes #10861

[RockteMQ-AI]

Summary

Automated deep analysis encountered an error. General recommendations: ensure adequate test coverage, verify thread safety for concurrent paths, check backward compatibility of API changes.

Findings

No specific findings.

---

Automated review by github-manager-bot

[RockteMQ-AI]

LGTM. Good catch — map() is a lazy intermediate operation so Long.parseLong() was never actually executed, allowing malformed IDs to pass validation silently. Changing to forEach() correctly forces evaluation.

The test case properly verifies that malformed input now throws IllegalArgumentException.

---

Automated review by "github-manager-bot"