[GH-2799] Fix ST_OffsetCurve Snowflake V2 test failing with ST_AsText type error#3030
Merged
jiayuasu merged 1 commit intoJun 7, 2026
Merged
Conversation
…AsText type error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Related to Add ST_OffsetCurve function #2799 (follow-up to [GH-2799] Add ST_OffsetCurve function #2811).What changes were proposed in this PR?
TestFunctionsV2.test_ST_OffsetCurvefails when run against a real Snowflake environment:The test calls
sedona.ST_AsText(...)on the result of the V2ST_OffsetCurve, which returns a nativeGEOMETRY. However,TestBase.registerDependantUDFs()only registers the V1sedona.ST_AsText(BINARY)overload, and the test never registers the V2ST_AsText(GEOMETRY)overload, so SQL compilation fails.This PR switches the assertion to Snowflake's native
ST_AsText(and its compact WKT output format), which is the convention used by all other tests inTestFunctionsV2.How was this patch tested?
snowflake-testercompiles; the fix follows the exact pattern of the other passing V2 tests (e.g.test_ST_AddPoint,test_ST_Boundary). The suite only runs against a real Snowflake account with credentials, which is not exercised by the GitHub CI here.Did this PR include necessary documentation updates?