Skip to content

[GH-2799] Fix ST_OffsetCurve Snowflake V2 test failing with ST_AsText type error#3030

Merged
jiayuasu merged 1 commit into
apache:masterfrom
jiayuasu:fix/snowflake-v2-offsetcurve-test
Jun 7, 2026
Merged

[GH-2799] Fix ST_OffsetCurve Snowflake V2 test failing with ST_AsText type error#3030
jiayuasu merged 1 commit into
apache:masterfrom
jiayuasu:fix/snowflake-v2-offsetcurve-test

Conversation

@jiayuasu

@jiayuasu jiayuasu commented Jun 7, 2026

Copy link
Copy Markdown
Member

Did you read the Contributor Guide?

Is this PR related to a ticket?

What changes were proposed in this PR?

TestFunctionsV2.test_ST_OffsetCurve fails when run against a real Snowflake environment:

net.snowflake.client.jdbc.SnowflakeSQLException: SQL compilation error: error line 1 at position 7
Invalid argument types for function 'ST_ASTEXT': (GEOMETRY)

The test calls sedona.ST_AsText(...) on the result of the V2 ST_OffsetCurve, which returns a native GEOMETRY. However, TestBase.registerDependantUDFs() only registers the V1 sedona.ST_AsText(BINARY) overload, and the test never registers the V2 ST_AsText(GEOMETRY) overload, so SQL compilation fails.

This PR switches the assertion to Snowflake's native ST_AsText (and its compact WKT output format), which is the convention used by all other tests in TestFunctionsV2.

How was this patch tested?

  • snowflake-tester compiles; the fix follows the exact pattern of the other passing V2 tests (e.g. test_ST_AddPoint, test_ST_Boundary). The suite only runs against a real Snowflake account with credentials, which is not exercised by the GitHub CI here.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jiayuasu jiayuasu added this to the sedona-1.9.1 milestone Jun 7, 2026
@jiayuasu jiayuasu merged commit d3bf96a into apache:master Jun 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant