test: replace placeholder spec with real MenuComponent tests #4993
Open
Ma77Ball wants to merge 6 commits intoapache:mainfrom
Open
test: replace placeholder spec with real MenuComponent tests #4993Ma77Ball wants to merge 6 commits intoapache:mainfrom
Ma77Ball wants to merge 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
/request-review @aglinxinyuan |
Contributor
Author
|
/request-review @copilot-pull-request-reviewer |
Contributor
Author
|
/unrequest-review @aglinxinyuan |
Contributor
Author
|
/request-review @aglinxinyuan |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds real unit test coverage for the workspace top-bar MenuComponent (previously a placeholder), and re-enables the spec in the Vitest test configuration so it runs in the normal frontend test suite.
Changes:
- Replaced the commented-out placeholder
menu.component.spec.tswith a full Vitest-based spec covering run/pause/resume, save/export, share modal, version history actions, and common menu handlers. - Removed
menu.component.spec.tsfrom the frontend test exclusion lists so it is compiled and executed by default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/tsconfig.spec.json | Re-enables menu.component.spec.ts by removing it from the spec exclude list. |
| frontend/src/app/workspace/component/menu/menu.component.spec.ts | Adds a real MenuComponent unit test suite with ~35 test cases for main menu behaviors. |
| frontend/angular.json | Re-enables menu.component.spec.ts by removing it from the test target’s exclude list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ma77Ball
force-pushed
the
test/menuComponent
branch
from
0bdef7c to
395deca
Compare
aglinxinyuan
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Replace the placeholder/commented-out body of menu.component.spec.ts with a real spec for MenuComponent, covering the top-bar menu's main actions: run/pause/resume, save, share, version history, and other menu handlers.
Any related issues, documentation, or discussions?
Closes: #4966
How was this PR tested?
npx ng test --watch=false --include='src/app/workspace/component/menu/menu.component.spec.ts' — 35 tests pass locally under the Vitest runner.
Was this PR authored or co-authored using generative AI tooling?
Co-Authored with Claude Opus 4.7 in Compliance with ASF