[CI] Remove unused lint Docker files#19872
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the ci_lint Docker image and its associated setup scripts, updating the Jenkins pipeline files and local scripts to run linting locally via pre-commit instead of inside a dedicated container. The reviewer noted that the fix parameter in the lint function in tests/scripts/ci.py is now unused and should be removed from the function signature and docstring.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| fix -- where possible (currently black and clang-format) edit files in place with formatting fixes | ||
| docker-image -- manually specify the docker image to use | ||
| interactive -- start a shell after running build / test scripts when using --docker-image | ||
| fix -- where possible edit files in place with formatting fixes |
There was a problem hiding this comment.
The fix parameter is no longer used anywhere in the lint function body. Since pre-commit runs formatting/fixing by default, this parameter has become redundant.\n\nTo avoid exposing a dead --fix option in the CLI, you should remove fix from the function signature and this docstring:\n\npython\ndef lint(interactive: bool = False, docker_image: str | None = None) -> None:\n \"\"\"\n Run lint checks locally.\n\n arguments:\n interactive -- start a shell after running build / test scripts when using --docker-image\n docker-image -- manually specify a docker image to use\n \"\"\"\n
This removes the unused
ci_lintDocker image path