Skip to content

[CI] Remove unused lint Docker files#19872

Open
tlopex wants to merge 1 commit into
apache:mainfrom
tlopex:remove-unused-ci-lint-docker-files
Open

[CI] Remove unused lint Docker files#19872
tlopex wants to merge 1 commit into
apache:mainfrom
tlopex:remove-unused-ci-lint-docker-files

Conversation

@tlopex

@tlopex tlopex commented Jun 23, 2026

Copy link
Copy Markdown
Member

This removes the unused ci_lint Docker image path

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the ci_lint Docker image and its associated setup scripts, updating the Jenkins pipeline files and local scripts to run linting locally via pre-commit instead of inside a dedicated container. The reviewer noted that the fix parameter in the lint function in tests/scripts/ci.py is now unused and should be removed from the function signature and docstring.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/scripts/ci.py
fix -- where possible (currently black and clang-format) edit files in place with formatting fixes
docker-image -- manually specify the docker image to use
interactive -- start a shell after running build / test scripts when using --docker-image
fix -- where possible edit files in place with formatting fixes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fix parameter is no longer used anywhere in the lint function body. Since pre-commit runs formatting/fixing by default, this parameter has become redundant.\n\nTo avoid exposing a dead --fix option in the CLI, you should remove fix from the function signature and this docstring:\n\npython\ndef lint(interactive: bool = False, docker_image: str | None = None) -> None:\n \"\"\"\n Run lint checks locally.\n\n arguments:\n interactive -- start a shell after running build / test scripts when using --docker-image\n docker-image -- manually specify a docker image to use\n \"\"\"\n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant