[ZEPPELIN-6674] Prove Shared Notebook Core port identity - #5481
voidmatcha wants to merge 1 commit into
Conversation
3df03a5 to
c5e9a9b
Compare
e7a0d5d to
56409c1
Compare
|
Some context the description leaves out: Why this PR is needed. This is part of ZEPPELIN-6627 and the second child of ZEPPELIN-6669, after ZEPPELIN-6670 (#5469) and before ZEPPELIN-6675. The React remote has no Module Federation shared scope, so a stateful Core imported by both the host and the remote would be two separate module instances. ZEPPELIN-6669 therefore makes the Angular host the single owner: it creates the port once and passes it to the remote through mount props. This PR proves that the remote receives that exact object across separate builds. Where the runtime-bundle rejection applies. The webpack plugin that fails a build bundling |
What is this PR for?
Prove that separately built Angular host and React remote code receive the exact same host-owned NotebookCorePort object. The build also rejects a React remote that bundles its own Shared Notebook Core runtime.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6674
How should this be tested?
cd zeppelin-web-angular npm run typecheck:notebook-core npm run build:notebook-core-port-proof npm run test:notebook-core-port-identityScreenshots (if appropriate)
Not applicable.
Questions: