[MINOR] Remove orphaned login modal backdrops before driving the navbar in Selenium tests - #5502
Open
voidmatcha wants to merge 1 commit into
Open
voidmatcha wants to merge 1 commit into
voidmatcha wants to merge 1 commit into
Conversation
…ar in Selenium tests
voidmatcha
force-pushed
the
fix/login-modal-orphan-backdrop
branch
from
September 26, 2026 01:45
5fc670d to
531237b
Compare
2 tasks
Contributor
|
This fixes a regression from #5497 (ZEPPELIN-6711). Before #5497,
Removing unowned backdrops once the modal is closed restores the cleanup I dropped, under the right condition. LGTM, thanks for tracking it down. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After ZEPPELIN-6711,
AuthenticationIT.testSimpleAuthenticationstill fails intermittently intest-selenium-with-spark-module-for-spark-3-5.#loginModalis already hidden, but whenlogoutUserclicks the navbar user menu,<div class="modal-backdrop fade">intercepts the click.Bootstrap 3.4.1 removes a backdrop through
this.$backdrop. When the login modal is shown and hidden again while an earlier transition is still running, that reference is replaced and the earlier backdrop is never removed. It stays over the page at opacity 0 and intercepts every click, so the existing retry inlogoutUserfails for the same reason.dismissLoginModal()now removes.modal-backdropelements that no displayed modal owns once the login modal is closed. An intercepted navbar click also logs the modal and backdrop state. The app-side behaviour that leaves the backdrop behind is not addressed here.What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
I ran only
AuthenticationITon a fork, with the same build as the CI job:All 13 failures logged the same state:
loginModal=modal fade ng-scope display=none, backdrops=[modal-backdrop fade]. With this PR, 44 of the 100 runs logged and removed such a backdrop, and all passed.Screenshots (if appropriate)
N/A
Questions: