fix(CI): stop re-uploading release assets to already-published releases - #18
Merged
Merged
Conversation
ci.yml already builds and publishes every binary when a version tag is pushed. release-assets.yml's `release: published` trigger then fired again and tried to rebuild and re-upload the same assets, which GitHub now rejects with "Cannot upload asset ... to an immutable release" once a release is published. Trim release-assets.yml down to just the README link update it's actually needed for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml'sreleasejob already builds every OS/arch binary and publishes the GitHub release on tag push.release-assets.ymlalso triggers onrelease: published, rebuilding the same binaries and trying to upload them again — which GitHub now rejects once a release is published ("Cannot upload asset ... to an immutable release"), as seen in run #32262281202.release-assets.ymlthat isn't redundant is the README release-link update (added in feature(CI): update release workflow to refresh README asset links #15), so this trims the workflow down to just that.Test plan
workflow_dispatchwith an existing tag) and confirmrelease-assets.ymlonly updates README links, without attempting a duplicate asset uploadci.yml's release job still publishes assets successfully