Skip to content

Students view names#123

Open
jensjvh wants to merge 2 commits into
apluslms:masterfrom
jensjvh:student-names
Open

Students view names#123
jensjvh wants to merge 2 commits into
apluslms:masterfrom
jensjvh:student-names

Conversation

@jensjvh

@jensjvh jensjvh commented Jul 16, 2026

Copy link
Copy Markdown

Description

What?

Changed the students view to display student names instead of student ids.

How?

Fetch the student names from the A+ API.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Playwright tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Comment thread provider/filesystem.py
logger.info('Skipping existing submission %s', submission_key)
return None
submission = insert_submission(exercise, submission_key, submitter_id)
submission = insert_submission(exercise, submission_key, submitter_id, '')

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if '' is good enough here, or if we can just retrieve the student name from somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant