ADFA-779: Fix oversized ADfA logo in Navigation Drawer sample - #1622
ADFA-779: Fix oversized ADfA logo in Navigation Drawer sample#1622davidschachterADFA wants to merge 2 commits into
Conversation
…h Code On The Go branding The nav drawer header (nav_header_main.xml) referenced a single density-independent drawable/ic_launcher_round.webp, so Android upscaled it past its native resolution on high-density screens, making the ADfA logo look oversized and soft. mipmap-xxxhdpi/ic_launcher(.round).webp had also been left on the old stock Android icon while every other density had been rebranded, mismatching the density-scale progression. Replaces the nav header logo with a self-contained vector (SVG-equivalent) using the current Code On The Go app icon design, and regenerates every mipmap density's launcher icons consistently at the correct scale. The phone glyph is scaled to 80% within the vector's circular badge so it sits fully inside the white circle instead of overflowing it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…mple with Code On The Go branding" This reverts commit 52d2bd6.
|
Closing this PR: Reverted the original commit in 728359e so this branch goes back to the CDN-downloaded |
Summary
drawable/ic_launcher_round.webp, so Android upscaled it past its native resolution on high-density screens — the ADfA logo appeared roughly twice as big as it should and looked soft.mipmap-xxxhdpi/ic_launcher.webpandic_launcher_round.webphad also been left on the old stock Android launcher icon while every other density had already been rebranded, breaking the density-scale progression (the ticket's "both mipmap-xxxhdpi icons are incorrect").Test plan
assets/core.cgt(the zip-based sample-template archive) with only the Navigation Drawer template's icon resources replaced — verified zip integrity, exact set of changed/added/removed entries, and XML well-formedness of the new vector drawables:templates-impl:testV8DebugUnitTestpassesFixes ADFA-779.
🤖 Generated with Claude Code