Skip to content

ADFA-779: Fix oversized ADfA logo in Navigation Drawer sample - #1622

Closed
davidschachterADFA wants to merge 2 commits into
stagefrom
bugfix/ADFA-779-navdrawer-sample-logo-size
Closed

ADFA-779: Fix oversized ADfA logo in Navigation Drawer sample#1622
davidschachterADFA wants to merge 2 commits into
stagefrom
bugfix/ADFA-779-navdrawer-sample-logo-size

Conversation

@davidschachterADFA

Copy link
Copy Markdown
Collaborator

Summary

  • The Navigation Drawer sample's drawer header referenced a single density-independent drawable/ic_launcher_round.webp, so Android upscaled it past its native resolution on high-density screens — the ADfA logo appeared roughly twice as big as it should and looked soft.
  • mipmap-xxxhdpi/ic_launcher.webp and ic_launcher_round.webp had also been left on the old stock Android launcher icon while every other density had already been rebranded, breaking the density-scale progression (the ticket's "both mipmap-xxxhdpi icons are incorrect").
  • Per the latest comment on the ticket, replaces the ADfA logo with the current Code On The Go app icon design (blue phone + green globe), as a self-contained vector drawable for the nav header (crisp at any density) and regenerates every mipmap density's launcher icons consistently at the correct scale.
  • The phone glyph is scaled to 80% within the vector's circular badge so it sits fully inside the white circle instead of overflowing it (caught via on-device visual check).

Test plan

  • Rebuilt assets/core.cgt (the zip-based sample-template archive) with only the Navigation Drawer template's icon resources replaced — verified zip integrity, exact set of changed/added/removed entries, and XML well-formedness of the new vector drawables
  • :templates-impl:testV8DebugUnitTest passes
  • Built and installed a debug APK on a physical arm64 device, created a fresh Navigation Drawer project, ran it, and confirmed the nav drawer header now shows the Code On The Go logo correctly sized and centered inside the white circle badge

Fixes ADFA-779.

🤖 Generated with Claude Code

…h Code On The Go branding

The nav drawer header (nav_header_main.xml) referenced a single
density-independent drawable/ic_launcher_round.webp, so Android upscaled
it past its native resolution on high-density screens, making the ADfA
logo look oversized and soft. mipmap-xxxhdpi/ic_launcher(.round).webp
had also been left on the old stock Android icon while every other
density had been rebranded, mismatching the density-scale progression.

Replaces the nav header logo with a self-contained vector (SVG-equivalent)
using the current Code On The Go app icon design, and regenerates every
mipmap density's launcher icons consistently at the correct scale. The
phone glyph is scaled to 80% within the vector's circular badge so it
sits fully inside the white circle instead of overflowing it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • assets/core.cgt
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e95e2a0f-5192-4f53-9666-214b5dfb2868

📥 Commits

Reviewing files that changed from the base of the PR and between 5305e52 and 52d2bd6.

📒 Files selected for processing (1)
  • assets/core.cgt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…mple with Code On The Go branding"

This reverts commit 52d2bd6.
@davidschachterADFA

Copy link
Copy Markdown
Collaborator Author

Closing this PR: assets/core.cgt shouldn't be hand-committed as a binary in this repo. It's meant to be reconstructed from the exploded templates/ source tree in appdevforall/dev-assets, by that repo's deploy.yml workflow, and this repo's build then downloads the rebuilt artifact from the CDN.

Reverted the original commit in 728359e so this branch goes back to the CDN-downloaded core.cgt. The actual fix (nav-header logo replacement, stale mipmap-xxxhdpi assets, adaptive icon foreground/background) is being redone at the source in a PR against appdevforall/dev-assets.

@davidschachterADFA
davidschachterADFA deleted the bugfix/ADFA-779-navdrawer-sample-logo-size branch August 4, 2026 00:55
@davidschachterADFA
davidschachterADFA restored the bugfix/ADFA-779-navdrawer-sample-logo-size branch August 4, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant