ADFA-5012: Rework build output options - #1626
Open
dara-abijo-adfa wants to merge 9 commits into
Open
Conversation
dara-abijo-adfa
commented
Aug 4, 2026
dara-abijo-adfa
commented
Contributor
- Remove the time between tasks
- Remove parenthesis from the time deltas
- Align the task texts vertically
- Add new icon to turn line numbers, timestamps, and time deltas on/off
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 Walkthrough
WalkthroughBuild output now supports timestamp and delta prefixes, configurable line numbers, timestamps, and deltas, and filtering against displayed text. A shared view-options interface connects ChangesBuild output formatting and filtering
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.kt (1)
409-412: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winApply view options to live output.
renderFilteredpasses both visibility states tofilterLines. Line 411 uses the defaulttruevalues instead. After a user hides timestamps or deltas, later output shows the hidden prefixes again. Filtering can also match hidden prefix text. Pass both view-model states here and add a regression test for output appended after each toggle.Proposed fix
val visibleText = - BuildOutputViewModel.filterLines(text, buildOutputViewModel.filterText.value) + BuildOutputViewModel.filterLines( + text, + buildOutputViewModel.filterText.value, + buildOutputViewModel.showTimestamps.value, + buildOutputViewModel.showDeltas.value, + )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.kt` around lines 409 - 412, Update the live-output filtering call in BuildOutputFragment to pass the current timestamp and delta visibility states from buildOutputViewModel, matching the arguments used by renderFiltered instead of relying on filterLines defaults. Ensure appended output preserves both toggle settings and add regression coverage for output received after each visibility toggle.
🧹 Nitpick comments (2)
app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.kt (1)
148-152: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDocument
setLineNumbersEnabled.Add KDoc for this public function. It changes both gutter visibility and divider width. The coding guideline requires KDoc for public functions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.kt` around lines 148 - 152, Add KDoc to the public setLineNumbersEnabled function describing that it enables or disables editor line numbers and updates the gutter divider width accordingly, including the meaning of the enabled parameter.Source: Coding guidelines
resources/src/main/res/values/strings.xml (1)
701-703: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRun Spotless on this file.
Lines 701-703 use spaces for indentation. Use tabs and reformat the complete changed file with Spotless. The repository rule requires tabs and file-level formatting when the Spotless ratchet applies.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@resources/src/main/res/values/strings.xml` around lines 701 - 703, Reformat the complete changed strings.xml file with Spotless, ensuring the entries log_filter_line_numbers, log_filter_timestamps, and log_filter_deltas use tab indentation rather than spaces and all other file-level formatting follows the repository’s Spotless ratchet rules.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@app/src/main/java/com/itsaky/androidide/handlers/EditorBuildEventListener.kt`:
- Around line 45-46: Update the timing state used for stepDeltaMs in
EditorBuildEventListener to use SystemClock.elapsedRealtime() for
buildStartTimeMs and lastOutputTimeMs, and update all related assignments and
delta calculations, including the logic around lines 106-109 and 183-188. Keep
System.currentTimeMillis() exclusively for wall-clock timestamps.
---
Outside diff comments:
In
`@app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.kt`:
- Around line 409-412: Update the live-output filtering call in
BuildOutputFragment to pass the current timestamp and delta visibility states
from buildOutputViewModel, matching the arguments used by renderFiltered instead
of relying on filterLines defaults. Ensure appended output preserves both toggle
settings and add regression coverage for output received after each visibility
toggle.
---
Nitpick comments:
In
`@app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.kt`:
- Around line 148-152: Add KDoc to the public setLineNumbersEnabled function
describing that it enables or disables editor line numbers and updates the
gutter divider width accordingly, including the meaning of the enabled
parameter.
In `@resources/src/main/res/values/strings.xml`:
- Around line 701-703: Reformat the complete changed strings.xml file with
Spotless, ensuring the entries log_filter_line_numbers, log_filter_timestamps,
and log_filter_deltas use tab indentation rather than spaces and all other
file-level formatting follows the repository’s Spotless ratchet rules.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5bdba0b6-a321-434c-82b6-c3243f8e567e
📒 Files selected for processing (11)
app/src/main/java/com/itsaky/androidide/fragments/output/BuildOutputFragment.ktapp/src/main/java/com/itsaky/androidide/fragments/output/LogFilterBarController.ktapp/src/main/java/com/itsaky/androidide/fragments/output/ViewOptionsOutputFragment.ktapp/src/main/java/com/itsaky/androidide/handlers/EditorBuildEventListener.ktapp/src/main/java/com/itsaky/androidide/ui/EditorBottomSheet.ktapp/src/main/java/com/itsaky/androidide/viewmodel/BuildOutputViewModel.ktapp/src/main/res/layout/layout_editor_bottom_sheet.xmlapp/src/test/java/com/itsaky/androidide/viewmodel/BuildOutputFilterTest.ktidetooltips/src/main/java/com/itsaky/androidide/idetooltips/TooltipTag.ktresources/src/main/res/drawable/ic_tune.xmlresources/src/main/res/values/strings.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.