ADFA-5068: Fix javac-services dependency scope without breaking AGP's consistency check

[davidschachterADFA]

Summary

Stacked on #1638 (ADFA-5053) -- this needs its java-compiler-carrier module and ADR 0012.

Follow-up from ADFA-5053's APK size audit (ADFA-5068). javac-services declared kotlin-stdlib, guava, :common, and :logger as implementation even though all four are resident, leaking androidx.core's ~2.87MB of dead resources plus duplicate guava/kotlin-stdlib bytecode into java-compiler-carrier.apk. Switching those to compileOnly broke AGP's compileClasspath.shouldResolveConsistentlyWith(runtimeClasspath) check one level up in java-compiler-impl, once :common's androidx graph stopped incidentally anchoring a high-enough version against AGP's own low-pinned viewbinding injection.

• Relocated ReflectUtils (the one :common symbol javac-services actually uses -- VMUtils/ILogger already lived in :shared/:logger) from :common to :shared.
• javac-services: common.kotlin/projects.common/projects.logger -> compileOnly(shared)/compileOnly(logger)/compileOnly(kotlin); dropped the guava line entirely (confirmed dead -- javac-services' own code never references it).
• Added a constraints {} block in java-compiler-impl pinning androidx.annotation/kotlin-stdlib/org.jetbrains:annotations to the versions already used elsewhere in the project. A constraint only rescopes an edge already reachable via AGP's injected viewbinding, so it doesn't reintroduce the duplication this fix removes -- just a version bump on a few KB of annotation classes.
• Documented the pattern in ADR 0012 (Negative/costs) as a third worked example of the resident-vs-isolated compileOnly rule.

Verified

From-scratch java-compiler-carrier:assembleV8Release:

• APK: 32.4MB -> 10.2MB
• resources.arsc: 2.27MB -> 40 bytes (empty; all androidx.core res/ entries gone)
• dex: 9.1+8.1+10.5+2.6MB across 5 files -> 8.4+2.1MB across 2

Test plan

• :shared:test, :subprojects:javac-services:testV8DebugUnitTest, :lsp:java-compiler-impl:testV8DebugUnitTest, :common:testV8DebugUnitTest all green
• Clean :subprojects:java-compiler-carrier:assembleV8Release succeeds and byte sizes confirmed above
• spotlessApply clean

🤖 Generated with Claude Code

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}