ADFA-4999 fix(maps): FQR pills wrap to multiple lines on narrow screens - #330
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Maps screen (Get More → Maps), the info pills sit in a fixed horizontal row that never wraps, so on narrow screens the last pill runs off the edge and gets clipped — the third FQR pill ("Online") ends up cut off. This affects both the Full-Quality Regions card (3 pills) and the "Rebuild the full maps" card (2 pills).
The fix reuses the FlowLayout the team already built for this screen (ADFA-4848), which flows children left-to-right and wraps when they don't fit, so no new dependency is needed. It just needs a small XML-inflatable constructor added, and the two pill rows in fragment_k2go_maps_landing.xml swapped over to it. After the change, pills wrap to a second line on small screens and stay on one line where there's room.
Tested on device.