Skip to content

ADFA-5000 fix(update): drive OTA verify from poller so the dialog can't hang on 'verifying' - #331

Merged
luisguzman-adfa merged 2 commits into
mainfrom
fix/ADFA-5000-ota-stuck-verifying
Aug 3, 2026
Merged

ADFA-5000 fix(update): drive OTA verify from poller so the dialog can't hang on 'verifying'#331
luisguzman-adfa merged 2 commits into
mainfrom
fix/ADFA-5000-ota-stuck-verifying

Conversation

@luisguzman-adfa

@luisguzman-adfa luisguzman-adfa commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Check for updates could get stuck on "Verifying signature…" and never reach
Install. Leaving that state depended only on ACTION_DOWNLOAD_COMPLETE, which is
lost when the download finishes in the background, in a receiver-registration race,
or on OEMs that don't deliver it. The poller had already seen the download succeed
and stopped, so verification was never triggered and the dialog hung.

The fix drives the verify/install step from UpdateViewModel's poller (which reads
DownloadManager directly and fires even without the broadcast). The poller and the
broadcast now funnel into one idempotent handleDownloadComplete(), so verification
runs exactly once; the broadcast stays as a fast-path backup, and the signature
check moved off the main thread. Only UpdateViewModel and UpdateController change.

Testing: a fake OtaDownloadGateway returning SUCCESSFUL confirms the poller
reaches verification without a broadcast; on device, point the updater at a local
update.json + a self-signed build and background the app mid-download — it should
still reach Install.

Tested on device

@luisguzman-adfa
luisguzman-adfa merged commit 44fcb0d into main Aug 3, 2026
3 checks passed
@luisguzman-adfa
luisguzman-adfa deleted the fix/ADFA-5000-ota-stuck-verifying branch August 3, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant