ADFA-4947: make the feedback FAB distinct from cards (teal tint) - #355
Merged
Conversation
The draggable feedback FAB used the default FloatingActionButton background, which resolved to the same surface as k2go_card_bg (k2go_surface) in both light and dark themes. Since the button floats and can be moved over any card, it blended into whatever card it hovered over and was hard to make out. Tint it in FeedbackFab.installOn with the teal accent (k2go_teal) and an on-teal icon (k2go_on_teal) — both flip day/night — so it stays distinct from the cards in either theme; the FAB's default elevation already provides the floating shadow. Applies to every redesign screen, since the FAB is created centrally in installOn. The terminal's FAB (main.xml, over a black background) is left as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The draggable feedback FAB used the default FloatingActionButton background, which resolved to the same surface as k2go_card_bg (k2go_surface) in both light and dark themes. Since the button floats and can be moved over any card, it blended into whatever card it hovered over and was hard to make out.
Tint it in FeedbackFab.installOn with the teal accent (k2go_teal) and an on-teal icon (k2go_on_teal) — both flip day/night — so it stays distinct from the cards in either theme; the FAB's default elevation already provides the floating shadow. Applies to every redesign screen, since the FAB is created centrally in installOn. The terminal's FAB (main.xml, over a black background) is left as-is.