Ship the staging root in the acme CA secret for letsencrypt-staging - #1335
Merged
Merged
Conversation
The secret hardcoded ISRG Root X1, the production root, while being selected for letsencrypt-staging too. Staging certificates chain to (STAGING) Pretend Pear X1, so BackendTLSPolicy validation against this secret could never succeed on a staging install. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charts/ace/templates/gateway/acme-ca.yamlis selected ascaCertificateRefsfor bothletsencryptandletsencrypt-staging(charts/ace/templates/gateway/route-nats.yaml:56-66), but itsca.crthardcoded a single certificate. Decoded, that is the production root:Staging certificates chain to a different, deliberately untrusted root — "(STAGING) Pretend Pear X1" (https://letsencrypt.org/docs/staging-environment/) — so on a
letsencrypt-staginginstall Envoy was handed a CA that cannot validate the backend, and theBackendTLSPolicycould never succeed.The secret now carries the matching root for the issuer in use. The PEM is https://letsencrypt.org/certs/staging/letsencrypt-stg-root-x1.pem verbatim. Nothing on the consuming side changes — the secret name is the same, so
route-nats.yamland the s3proxy policy in #1334 pick it up as-is.Verification
Rendered the template with each issuer and piped the resulting
ca.crtthroughopenssl x509:global.infra.tls.issuerca.crtletsencrypt96:BC:EC:06…letsencrypt-stagingE7:05:70:A9…caScope
This affects nats today — unlike the s3proxy policy in #1334,
route-nats.yamlrenders on every gateway install. It only bites deployments running against the staging ACME endpoint.