Fix MaxScale securityContext UID and widen ProxySQL backend AppBinding filter - #1182
Merged
Merged
Conversation
…g filter MaxScale runs as uid 997, not 999; give it its own container securityContext helper and pod fsGroup default. ProxySQL can route to MariaDB and PerconaXtraDB backends, so the backend AppBinding dropdown now accepts those types in addition to MySQL. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
Member
Author
|
maxscale 997 part is done here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MariaDB MaxScale (
kubedbcom-mariadb-editor-options)MaxScale runs as uid 997, not 999. Added a
maxscale.container.securityContexthelper and changed the MaxScale podfsGroupdefault; MariaDB and its sidecars keep 999. Thespec.openshift.securityContext.runAsUseroverride still takes precedence.ProxySQL backend (
kubedbcom-proxysql-editor-options)getAppBindings()only listedkubedb.com/mysqlAppBindings. ProxySQL can also front MariaDB and PerconaXtraDB, so the filter now acceptskubedb.com/mariadbandkubedb.com/perconaxtradb.Verified with
helm template charts/kubedbcom-mariadb-editor-options --set spec.mode=MariaDBReplication: MaxScale renders 997, MariaDB 999.