Remove dead cmd/build-image call from opensearch workflows - #119
Merged
ArnobKumarSaha merged 1 commit intoSep 15, 2026
Merged
Conversation
The opensearch and opensearch-dashboards images are built and pushed entirely
by upstream's build-image-multi-arch.sh (which downloads the released tarball by
version) followed by 'crane cp' for the dated tag. The trailing
'go run cmd/build-image/main.go --name=opensearch...' line never did anything
useful and always failed the job:
1. It runs from inside opensearch-build/docker/release (the script cd'd there),
so the relative path resolves to nothing:
Error: stat cmd/build-image/main.go: no such file or directory
2. Even from the repo root it would panic: cmd/build-image reads
library/<app>/app.json via FindBlock, but opensearch has no app.json (it was
removed in dfef1b0) because it does not use the tag-checkout + cherry-pick +
docker-build flow that app.json describes.
The image is already built/pushed before this line, so removing it makes the job
report its true (green) status without changing any image output.
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
ArnobKumarSaha
approved these changes
Sep 15, 2026
ArnobKumarSaha
deleted the
fix-opensearch-remove-dead-build-image-call
branch
September 15, 2026 05:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opensearch and opensearch-dashboards images are built and pushed entirely by upstream's build-image-multi-arch.sh (which downloads the released tarball by version) followed by 'crane cp' for the dated tag. The trailing 'go run cmd/build-image/main.go --name=opensearch...' line never did anything useful and always failed the job:
The image is already built/pushed before this line, so removing it makes the job report its true (green) status without changing any image output.