fix(APP-1231): show value field for payable allowed actions - #1422
Open
harryburger wants to merge 2 commits into
Open
harryburger wants to merge 2 commits into
harryburger wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Review effort: Lite
Findings: None
What changed in this PR
Forwards allowed-action function mutability so payable actions display the native value field.
Changes:
- Added optional
stateMutabilityto decoded allowed actions. - Passed it into constructed custom actions.
- Added coverage for payable, nonpayable, and missing metadata.
| File | Description |
|---|---|
| apps/app/src/modules/governance/components/actionComposer/actionComposerUtils.ts | Updated as part of this pull request. |
| apps/app/src/modules/governance/components/actionComposer/actionComposerUtils.test.ts | Updated as part of this pull request. |
| apps/app/src/modules/governance/api/executeSelectorsService/domain/allowedActionDecoded.ts | Updated as part of this pull request. |
| .changeset/app-1231-payable-allowed-actions.md | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task: https://linear.app/aragon/issue/APP-1231/show-value-field-for-payable-allowed-actions
When a payable function is in the only-allowed actions list, the value field was not rendered. The allowed actions never passed
stateMutabilityto the action, so it was always treated as non payable.Now
getAllowedActionItemsforwardsdecoded.stateMutabilityto the actioninputData, so payable ones show the value field.Needs aragon/app-backend#1589 to return
stateMutabilityon allowed actions. The field is optional, so without it nothing changes.Tested locally against sandbox (backend PR is deployed there) on the test DAO, WETH9
depositnow shows the value field and the value is set on the action.Type of Change
Developer Checklist:
Review Checklist: