fix(logging): keep debug previews on UTF-8 boundaries - #80
Merged
Merged
Conversation
Debug previews byte-sliced their input at a fixed bound, which panics when the bound lands inside a multibyte character. This affected tool result previews in the runtime and model reply previews in the Anthropic and OpenAI clients, where non-ASCII prose such as an em-dash is common. Route all four previews through the existing char-aware truncation helper instead of hand-rolling a boundary walk, and cover the 100-byte bound alongside the helper's other regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug logging sliced tool results and model replies at fixed byte offsets, which could panic when the cut landed inside a multibyte character. Use the existing character-aware truncation helper for all four previews and cover both preview lengths with a regression test.
The change only affects debug previews; tool results and model replies remain unchanged.