Make read-only shortcut review optional and enforce completion gates - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only repository investigations currently require an independent model reviewer through the compatibility command, while the newer observe/auto routes omit several deterministic completion checks. Make the reviewer optional and apply the common completion checks consistently.
complete --read-only --result-file PATHwithout a reviewer. Explicit--reviewercalls still require matching sealed evidence and now verify its recorded output hash.Validation: 94 Rust unit tests, 20 CLI migration contracts, the complete shell contract suite (
tests/run.sh), mock orchestration E2E, lifecycle regressions, formatting, and diff checks passed. Shell tests use system/bin/bash; the initial Homebrew Bash invocation stalled during mock fixture setup.Linux UID/Landlock and real deployed prod-mcp integration were not verified on this macOS host. Deployment acceptance and the pre-existing external-only pending-request/live-role accounting gap remain explicit TODOs. No production operation or deployment was performed.
Based on freshly fetched
origin/mainatfcf23b6.