Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0a0d39cca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ``"none"``. Supported values are ``none``, ``low``, ``medium``, | ||
| ``high``, ``xhigh``, and ``max``. | ||
| Reasoning effort for manually verified Argo GPT-5.6 and Claude Opus | ||
| models. GPT-5.6 defaults to ``"none"``; Claude defaults to ``"high"``. |
There was a problem hiding this comment.
Document the actual medium reasoning defaults
When users instantiate ChemGraph without reasoning_effort, _resolve_reasoning_effort now selects medium for both GPT-5.6 and Claude Opus models, but this public constructor documentation still advertises none and high. This can cause users to misinterpret or incorrectly reproduce an experiment; update the docstring to state that both families default to medium.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
Summary
--reasoning-effortsupport to the ChemGraph CLI and TOML configuration flow.mediumas the default reasoning effort for both model families while preserving explicit user selections.output_config.effortwithout explicitly enabling adaptive thinking.Related issues
None.
Type of change
How was this tested?
git ls-files -z -- "*.py" | xargs -0 ruff checkpytest tests/test_llm_agent.py tests/test_loader_pr2.py tests/test_main_agent_cli.py -q: 88 passedpytest tests/ -k "not tblite": 711 passed, 30 skipped, 2 deselectedgit diff --checkChecklist
mainand targetsmainruff check .passes in a clean checkoutpytest tests/ -k "not tblite"passes in a clean checkout