Fix incorrect assumption about erc7201 constant function call#16672
Fix incorrect assumption about erc7201 constant function call#16672matheusaaguiar wants to merge 3 commits into
Conversation
matheusaaguiar
changed the title
nikola-matic
left a comment
nikola-matic
left a comment
There was a problem hiding this comment.
I'd say this warrants a changelog - it's a user visible change after all.
| case FunctionType::Kind::ERC7201: | ||
| { | ||
| solAssert(_functionCall.arguments().size() == 1); | ||
| if (_functionCall.arguments().size() != 1) |
There was a problem hiding this comment.
The problem here is that for certain cases, like array lengths, the constant folding happens before, during DeclarationTypeChecker visits... I could add that there, but feels a bit out of place too.
At first, I wanted to rely on TypeChecker and missed that this could be triggered before it was verified (see this comment)
matheusaaguiar
force-pushed
the
fix_erc7201_invalid_param_number_ice
branch
3 times, most recently
from
7284376 to
c877f69
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
Bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
Bot
added
the
stale
cameel
removed
the
stale
matheusaaguiar
force-pushed
the
fix_erc7201_invalid_param_number_ice
branch
from
c877f69 to
79eff37
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
Bot
added
the
stale
|
This pull request was closed due to a lack of activity for 7 days after it was stale. |
nikola-matic
removed
stale
3 participants
Fix #16633.